-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(color): add --no-color
flag
#5368
base: master
Are you sure you want to change the base?
Conversation
- add --no-color / -Q CLI argument - initialize colorama based on that arg
so that `pytest -m arg_parser` can be run to test only the updated argument handling
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5368 +/- ##
==========================================
- Coverage 89.38% 89.33% -0.05%
==========================================
Files 1018 1019 +1
Lines 31278 31348 +70
==========================================
+ Hits 27959 28006 +47
- Misses 3319 3342 +23 ☔ View full report in Codecov by Sentry. |
Hi @MrSecure, thanks a lot for your contribution! We will review this asap. |
Should the |
The Regarding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please review my comments 🙏🏼
else: | ||
colorama_init(strip=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else: | |
colorama_init(strip=False) |
Is this needed?
Context
Fix #5294
Description
init
--no-color
/-Q
command line option (defaultFalse
)no_color
option to control colorama init.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.