feat(iam): add new check iam_policy_cloudshell_admin_not_attached
#5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith a method to describe every user,group and role that use cloudshell policy and test for the method
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5437 +/- ##
==========================================
+ Coverage 89.21% 89.34% +0.12%
==========================================
Files 1044 1054 +10
Lines 32225 32686 +461
==========================================
+ Hits 28750 29203 +453
- Misses 3475 3483 +8 ☔ View full report in Codecov by Sentry. |
sergargar
changed the title
iam_cloudshell_admin_policy_not_attachediam_policy_cloudshell_admin_not_attached
sergargar
reviewed
Oct 17, 2024
| "SubServiceName": "", | ||
| "ResourceIdTemplate": "arn:aws:iam::{account-id}:{resource-type}/{resource-id}", | ||
| "Severity": "medium", | ||
| "ResourceType": "AwsIamRole, AwsIamUser, AwsIamGroup", |
There was a problem hiding this comment.
Suggested change
| "ResourceType": "AwsIamRole, AwsIamUser, AwsIamGroup", | |
| "ResourceType": "AwsIamPolicy", |
sergargar
reviewed
Oct 17, 2024
| def _list_entities_for_policy(self, policy_arn): | ||
| logger.info("IAM - List Entities Role For Policy...") | ||
| try: | ||
| entities = [] |
There was a problem hiding this comment.
Please, make entities a dictionary with keys as User, Group, Role with a list for each entity.
There was a problem hiding this comment.
So we can show in the status extended the type of entities too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add a new check to ensure IAM identities (users, roles, or groups) don't have the AWS managed policy
AWSCloudShellFullAccessattached. The control fails if this policy is present.AWSCloudShellFullAccessprovides full access to AWS CloudShell, including file upload/download capabilities and sudo permissions, which can pose security risks. Adhere to the principle of least privilege and avoid attaching this broad policy.Description
Added new check
iam_cloudshell_admin_policy_not_attachedwith respective unit tests. Added new attributeentities_attached_to_cloudshell_policywith method_list_entities_for_policyand a test for the method.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.