Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(waf): add new check waf_global_webacl_with_rules #5469

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HugoPBrito
Copy link
Member

Context

AWS WAF Classic global web ACLs (Web Access Control Lists) are essential for controlling access to web applications. A web ACL can include a set of rules or rule groups that filter and manage HTTP and HTTPS requests. These rules help define which traffic should be allowed, blocked, or counted, improving security and controlling access to your AWS resources such as CloudFront distributions.

Description

This check verifies whether an AWS WAF Classic global web ACL contains at least one rule or rule group. If no rules or rule groups are present, the web traffic might pass without inspection, leaving the application vulnerable to attacks.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners October 18, 2024 14:44
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.44%. Comparing base (23a20a5) to head (e0ea458).

Files with missing lines Patch % Lines
prowler/providers/aws/services/waf/waf_service.py 87.50% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5469      +/-   ##
==========================================
- Coverage   89.45%   89.44%   -0.01%     
==========================================
  Files        1059     1061       +2     
  Lines       32855    32928      +73     
==========================================
+ Hits        29390    29454      +64     
- Misses       3465     3474       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant