-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: vendorize detect-secrets
dependency
#5472
Open
sergargar
wants to merge
19
commits into
master
Choose a base branch
from
PRWLR-5082-solve-pypi-upload-errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
github_actions
Pull requests that update GitHub Actions code
label
Oct 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5472 +/- ##
==========================================
- Coverage 89.45% 89.43% -0.02%
==========================================
Files 1059 1059
Lines 32855 32855
==========================================
- Hits 29390 29385 -5
- Misses 3465 3470 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR resolves the PyPI upload issue caused by the use of a direct GitHub dependency for
detect-secrets
, which is not allowed by PyPI.Description
detect-secrets
: The library has been added toprowler/lib/detect-secrets
to include the latest changes from the master branch, as the PyPI version is outdated.pyproject.toml
: The dependency is now referenced locally fromprowler/lib/detect-secrets
instead of GitHub.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.