Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vendorize detect-secrets dependency #5472

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

sergargar
Copy link
Member

Context

This PR resolves the PyPI upload issue caused by the use of a direct GitHub dependency for detect-secrets, which is not allowed by PyPI.

Description

  • Vendorized detect-secrets: The library has been added to prowler/lib/detect-secrets to include the latest changes from the master branch, as the PyPI version is outdated.
  • Updated pyproject.toml: The dependency is now referenced locally from prowler/lib/detect-secrets instead of GitHub.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested review from a team as code owners October 18, 2024 16:56
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (23a20a5) to head (0e2fb9c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5472      +/-   ##
==========================================
- Coverage   89.45%   89.43%   -0.02%     
==========================================
  Files        1059     1059              
  Lines       32855    32855              
==========================================
- Hits        29390    29385       -5     
- Misses       3465     3470       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant