Refactor subcommands #264
Open
Refactor subcommands #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References pypa#262
This change yanks out each subcommand from `flit/__init__.py` and moves them to an isolated file in `flit/subcommand`. Additionally, `flit.subcommand.register` has been implemented to dynamically load these subcommands and make them available via argparse. See `flit/subcommand/__init__.py` for details. This could have been implemented as classes/subclasses which would avoid import caching and aid testing, but, in my opinion the structure with modules is simpler.
The "stderr" stream was redirected to stdout which made the test not representative of the intended use-case and also caused issues on travis
|
nicely organized, and lots of tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #263, this is a refactoring for subcommands.
Let me know what you think. It builds on top of my code from #263 so this also includes the commit of the
info --versioncommand. I kept them separate in case this refactoring is not something you like in terms of code-style.