install should not do full lock resolution, as that is the purpose of pipenv lock #6276
Conversation
… goal of not doing full lock resolution, which was intended as we moved to 2024.x release series.
…prevent lock resolution failure. Remove caching properties that can become stale.
… category packages
… test passed locally without this change for some reason)
| "colorama", | ||
| "atomicwrites", | ||
| "six", |
There was a problem hiding this comment.
This should be acceptable because its the default non-sorting case; it is technically a behavioral change that re-installing something moves it to the bottom of the Pipfile, but I feel we get closed to reducing some complexity around the Pipfile creation, and writing in this PR -- it doesn't seem to negatively impact performance either.
| @@ -379,9 +379,7 @@ def test_system_and_deploy_work(pipenv_instance_private_pypi): | |||
| @pytest.mark.basic | |||
| @pytest.mark.install | |||
| def test_install_creates_pipfile(pipenv_instance_pypi): | |||
| with pipenv_instance_pypi() as p: | |||
There was a problem hiding this comment.
I had to debug this test, and I figure may as well use this simplification that existed in the fixture to not create the pipfile in the first place.
| @pytest.mark.skipif( | ||
| sys.version_info >= (3, 12), reason="Package does not work with Python 3.12" | ||
| ) | ||
| @pytest.mark.install |
There was a problem hiding this comment.
Upgrading this package meant the test could pass on python 3.13 even
| def test_install_remote_wheel_file_with_extras(pipenv_instance_pypi): | ||
| with pipenv_instance_pypi() as p: | ||
| c = p.pipenv( | ||
| "install fastapi[dev]@https://files.pythonhosted.org/packages/4e/1a/04887c641b67e6649bde845b9a631f73a7abfbe3afda83957e09b95d88eb/fastapi-0.95.2-py3-none-any.whl" | ||
| "install -v fastapi[standard]@https://files.pythonhosted.org/packages/c9/14/bbe7776356ef01f830f8085ca3ac2aea59c73727b6ffaa757abeb7d2900b/fastapi-0.115.2-py3-none-any.whl" |
There was a problem hiding this comment.
dev is no longer an extra in newer fastapi versions.
| @@ -143,9 +143,6 @@ def test_install_named_index_alias(pipenv_instance_private_pypi): | |||
| @pytest.mark.index | |||
| @pytest.mark.install | |||
| @pytest.mark.needs_internet | |||
| @pytest.mark.skipif( | |||
| sys.version_info >= (3, 12), reason="Package does not work with Python 3.12" | |||
| ) | |||
There was a problem hiding this comment.
This test was failing at one point, and I discovered that it could pass on 3.13 -- I think we had a different bug at one point that lead to this.
| @@ -5,7 +5,7 @@ | |||
| import sys | |||
| import tempfile | |||
| import warnings | |||
| from functools import cached_property, lru_cache | |||
| from functools import lru_cache | |||
There was a problem hiding this comment.
Too many side-effects encountered in various issue reports relate to our current structure and usage of caching. I am in favor of correcting core functionality, and revisiting small gaps in performance down the road in a more thoughtful way.
| @@ -1132,6 +1132,11 @@ def install_req_from_pipfile(name, pipfile): | |||
| version = "" | |||
| req_str = f"{name}{extras_str}{version}" | |||
|
|
|||
| # Handle markers before constructing InstallRequirement | |||
There was a problem hiding this comment.
AI suggested this change -- awaiting confirmation it fixes relevant issues.
| @@ -164,7 +160,7 @@ def upgrade( | |||
| which=project._which, | |||
| project=project, | |||
| lockfile={}, | |||
| category="default", | |||
There was a problem hiding this comment.
This was definitely a bug in the update/upgrade path, it couldn't have worked too great for non-default categories.
| @@ -45,13 +45,11 @@ def do_sync( | |||
| do_init( | |||
| project, | |||
| allow_global=system, | |||
| requirements_dir=requirements_dir, | |||
The issue and fixes
Fixes #6267
Possibly fixes #6231
Possibly fixes #6187
Possibly fixes #6068
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.