Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit survey with sections #115

Merged
merged 13 commits into from
Aug 13, 2019
Merged

Conversation

martinagvilas
Copy link
Member

Hi, I edited the survey and added sections (and some questions) inspired by the links provided in #91.

I also changed the employment questions that refered to IT jobs to refer to more general aspects, to avoid assuming background.

Let me know what you think.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, couple of comments, but the changes here are great, so happy to get this merged and continue with other changes in a follow up.

SURVEY.md Outdated
- yes
- no

### 3.3. What do you use Pandas for? (multiple choice/single choice)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 3.3. What do you use Pandas for? (multiple choice/single choice)
### 3.3. What do you use pandas for? (multiple choice/single choice)


### 5.1. Would you be interested in receiving a scholarship for your contribution to the pandas-mentoring team 2019?
- yes
- no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me (and the pandas core devs who can find grant opportunities) would be useful to also know information like how many hours per week could be spent in the internship. And it's trickier, but information on how much money we need for the scholarships. Programs like GSoC and others decide it for us, but for NumFOCUS grants, grants directly from pandas funds, or corporate partnerships, would be useful to know.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to know! I can add them to this PR

- Not sure

### Experience in IT
### 2.3. For how long have you kept this job role?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my interests, I find more relevant the previous question or total years of experience (with pandas, python or in IT in general). Happy to also have this, but I'd like to have the others.

And I'm not sure if it's useful to have bins, all the questions with numerical values (age, years of experience...) can probably ask for the exact value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, makes sense! I will re-add the deleted questions. I also agree with the age values, I can change the output of these questions as well.

@martinagvilas
Copy link
Member Author

I added the suggestions, let me know if this looks better now.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I guess people may still want contribute things to the survey, but surely better in follow ups that in comments here.

Copy link
Member

@sara-02 sara-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvements/suggestion in language.

SURVEY.md Outdated

### 5.4. What amount of money do you expect to receive from this scholarship?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...amount(USD $)...

SURVEY.md Outdated

### 4.3. Is this the first open-source project you contribute to?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...you are contributing...

SURVEY.md Outdated

### 3.5. For how long have you been using python?

### 3.6. Which of pandas capabilities are most important to you?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...of the following...

@sara-02
Copy link
Member

sara-02 commented Aug 13, 2019

@martinagvilas Minor nitpicking, just to improve the language.

@martinagvilas
Copy link
Member Author

@sara-02 great! I made the changes you suggested, let me know if it looks good now.

Copy link
Member

@sara-02 sara-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sara-02
Copy link
Member

sara-02 commented Aug 13, 2019

@martinagvilas We are good.

@sara-02 sara-02 merged commit 72baf46 into python-sprints:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants