Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use 1 as default sockets value #1433

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

lj3954
Copy link
Contributor

@lj3954 lj3954 commented Aug 24, 2024

Description

lscpu populates the sockets field with '-' if the number of sockets it's determined is equal to 0 (which is accurately treated as a null value). Replace this value with 1 to fix invalid values being passed to qemu.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions

@flexiondotorg flexiondotorg merged commit 35f8e93 into quickemu-project:master Aug 27, 2024
4 checks passed
@lj3954 lj3954 deleted the fix_sockets branch August 27, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emu-system-x86_64: Parameter 'smp.sockets' expects integer
2 participants