fix: dynamic grep latest MX linux and sort Kolibri #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuxVinyards
changed the title
TuxVinyards
changed the title
Also as requested by code validation for github actions Amend the commit message to match the pull request title, or *add another commit.*
tested, loads and runs ...
make code style more consistent move basename line into better position
philclifford
requested changes
Oct 17, 2024
TuxVinyards
changed the title
|
See https://www.conventionalcommits.org/en/v1.0.0/ |
hoping that spending time on this space will help fix the continuum ...
Header files are not always consistent in their format. 'Location' can sometimes be capitalized, hence the '-i' Regex can too easily turn into lines of indecipherable hieroglyphics but in this case, due to variance as cited above, regex would probably be more robust than grepping for 'location:' (with a colon) and if the header was reorganised then '-m 1' could end up up failing.
On further research and reflection to 503e083 There are two types of location headers 'Location:' and 'Content-Location:' so using the regex caret anchor ^'location' could fail when direct links are used as it would only look for 'location' at the start of the line. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers " An HTTP header consists of its case-insensitive name followed by a colon (:), then by its value." There is also the issue of different versions of grep having different regex capabilities to consider. As such, I am now viewing a grep with -i 'location:' (with a colon) as the more reliable general solution and suggest that this is the one to go with.
philclifford
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
FAIL: mxlinux-23.3-Xfce https://sourceforge.net/projects/mx-linux/files/Final/Xfce/MX-23.3_x64.iso
FAIL: mxlinux-23.3-KDE https://sourceforge.net/projects/mx-linux/files/Final/KDE/MX-23.3_KDE_x64.iso
FAIL: mxlinux-23.3-Fluxbox https://sourceforge.net/projects/mx-linux/files/Final/Fluxbox/MX-23.3_fluxbox_x64.iso
Type of change
Hopefully 'maintenance free'
Checklist:
[ x] I have performed a self-review of my code
[ x] I have tested my code in common scenarios and confirmed there are no regressions
[ x] I have added comments to my code, particularly in hard-to-understand sections