Drag-Drop feature #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,6 +111,8 @@ const fileComponentSource = { | |||
| endDrag(props, monitor, component) { | |||
| // console.log("EndDrag", monitor.getDropResult()); | |||
| console.log(props, "Component:", component); | |||
| ReactDOM.render(modalElement, document.getElementById("modalElement")); | |||
There was a problem hiding this comment.
The problem is that here we'll have to wait for the component to be rendered and processed completely and only after that getting the value of operation will be possible.
As of now, before the element is rendered completely, the code runs to console.log(operation); and then to try block ignoring the modalElement.......can Async-Await deal with this problem?
There was a problem hiding this comment.
One way to go about it could be to delay the calling of performCopyMoveOperation() till the modal opens and closes.
|
@negative0 any reviews? |
ridhishjain-zepto
changed the title
|
@ridhishjain, would you like to complete this? |
|
I've not checked the repo for a long time, if u can guide me through it? |
|
Sure. What do you need?
…On Thu, 16 Jul, 2020, 3:50 AM ridhishjain, ***@***.***> wrote:
I've not checked the repo for a long time, if u can guide me through it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5LNYBLPJO53WMR4WLIR4DR3YTRHANCNFSM4KR4BS3A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#fixes #53