Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #16

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Improve CI #16

merged 3 commits into from
Jan 22, 2024

Conversation

rnestler
Copy link
Member

@rnestler rnestler commented Jan 22, 2024

Linting will be fixed by #15

@rnestler rnestler requested a review from a team January 22, 2024 11:26
@rnestler rnestler self-assigned this Jan 22, 2024
coorasse
coorasse previously approved these changes Jan 22, 2024
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is time to switch to "main" instead of "master"

@rnestler
Copy link
Member Author

Maybe is time to switch to "main" instead of "master"

Good point. But I don't seem to have permission to change settings in this project. And neither does the renuobot account which I tried.

@rnestler
Copy link
Member Author

Switched the default branch to main.

Previously the CI would be triggered twice: Once for the branch and once
for the PR.
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rnestler rnestler merged commit 2fccb37 into main Jan 22, 2024
5 checks passed
@rnestler rnestler deleted the improve-ci branch January 22, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants