Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thread spans through #274

Merged
merged 1 commit into from
Oct 14, 2024
Merged

thread spans through #274

merged 1 commit into from
Oct 14, 2024

Conversation

jackyzha0
Copy link
Member

Why

  • being able to add things to the proc span directly from a handler is nice

What changed

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@jackyzha0 jackyzha0 requested a review from a team as a code owner October 14, 2024 19:45
@jackyzha0 jackyzha0 requested review from bradymadden97 and Monkatraz and removed request for a team October 14, 2024 19:45
@jackyzha0 jackyzha0 merged commit 258fe9f into main Oct 14, 2024
4 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/add-spans-to-proc-ctx branch October 14, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masad-frost masad-frost masad-frost approved these changes

@bradymadden97 bradymadden97 Awaiting requested review from bradymadden97 bradymadden97 is a code owner automatically assigned from replit/workspace-infrastructure-and-editor

@Monkatraz Monkatraz Awaiting requested review from Monkatraz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackyzha0 @masad-frost