-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1019 enable staff to update fosterer info #1052
1019 enable staff to update fosterer info #1052
Conversation
@Meri-MG thanks for the PR - it might take me a couple days before I get to review it - busy times. Hopefully someone else can also drop a review. Please run |
@Meri-MG no need to use turbo frames! That was optional. The redirects work fine. We could use a frame to handle it all in the same page without redirects, but that is not necessary. Could you please update the edit buttons to match those used elsewhere? See the staff FAQ page for example. I will do a full review, soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @Meri-MG just a couple small comments
hello, @kasugaijin , had some busy days and addressed the feedback just now. I reverted the change with the form errors partial. thank you 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! Thank you @Meri-MG
🔗 Issue
#1019
✍️ Description
FosterersController
update_fosterers
ability toFostererInvitationPolicy
for update? and edit? actions(I figured nobody should be seeing the edit form if they don't have permission to perform the update action?)Joined At
column from the fosterers tableP.S. @kasugaijin I'm unsure why we are advised to use turbo frames here?
📷 Screenshots/Demos