Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1019 enable staff to update fosterer info #1052

Merged

Conversation

Meri-MG
Copy link
Contributor

@Meri-MG Meri-MG commented Oct 9, 2024

🔗 Issue

#1019

✍️ Description

  • Added update and edit action to the FosterersController
  • Added update_fosterers ability to FostererInvitationPolicy for update? and edit? actions(I figured nobody should be seeing the edit form if they don't have permission to perform the update action?)
  • Removed Joined At column from the fosterers table
  • Added email, and phone columns to the table and left action column for the Edit link
  • Moved form errors into the partial

P.S. @kasugaijin I'm unsure why we are advised to use turbo frames here?

📷 Screenshots/Demos

Screenshot 2024-10-10 at 13 03 43
Screenshot 2024-10-09 at 14 17 14

dave

@kasugaijin
Copy link
Collaborator

kasugaijin commented Oct 9, 2024

@Meri-MG thanks for the PR - it might take me a couple days before I get to review it - busy times. Hopefully someone else can also drop a review.

Please run rails standard:fix to pass the linter

@kasugaijin
Copy link
Collaborator

@Meri-MG no need to use turbo frames! That was optional. The redirects work fine. We could use a frame to handle it all in the same page without redirects, but that is not necessary.

Could you please update the edit buttons to match those used elsewhere? See the staff FAQ page for example.
image

I will do a full review, soon!

Copy link
Collaborator

@kasugaijin kasugaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Meri-MG just a couple small comments

@Meri-MG
Copy link
Contributor Author

Meri-MG commented Oct 16, 2024

hello, @kasugaijin , had some busy days and addressed the feedback just now. I reverted the change with the form errors partial. thank you 🙏

Copy link
Collaborator

@kasugaijin kasugaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! Thank you @Meri-MG

@kasugaijin kasugaijin merged commit addb4d6 into rubyforgood:main Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants