885 - Add tests for DefaultPetTask refactor #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasugaijin
reviewed
Oct 9, 2024
| default_pet_task: {name: "New Dog Task", species: "Dog", due_in_days: 5} | ||
| } | ||
| has_dog_species = DefaultPetTask.find_by_name("New Dog Task").Dog? | ||
| assert_equal true, has_dog_species |
There was a problem hiding this comment.
Ah so this is testing that it creates a new DefaultPetTask - but what I meant is that it creates a new Task on a new Pet.
If you look in app/services/organizations we have the DefaultPetTaskService which gets called when we create a new pet, and adds a Task for each DefaultPetTask for that species.
If you look in the Organizations::Staff::PetsController #create you will see we call the service on the new pet
So, to test, we want to
- create the default pet task for dog
- create a dog
- verify that dog has a task with the same name as the default pet task for dogs
- do the same for cat
does that make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
#885
✍️ Description