1021 Refactor Pet instance method to use the Match model instead of the AdopterApplication model #1055
Conversation
|
I just added a second commit that is purely performance related. It probably isn't a priority at the moment, but I noticed while refactoring the Before changes: After changes: You can see the number of Active Record queries goes down significantly. I can put this into a separate PR, or just stash these changes for now, if we don't want to look at performance yet. |
coalest
force-pushed
the
1021/pet-refactor-instance-method-to-use-the-match-model-instead-of-the-adopter-application-model
branch
from
8f042e6
to
d37b498
Compare
coalest
force-pushed
the
1021/pet-refactor-instance-method-to-use-the-match-model-instead-of-the-adopter-application-model
branch
from
d37b498
to
74a8331
Compare
| @@ -8,10 +8,9 @@ class Organizations::AdoptablePetsController < Organizations::BaseController | |||
| helper_method :get_animals | |||
|
|
|||
| def index | |||
| @q = authorized_scope(Pet.includes(:adopter_applications, images_attachments: :blob), | |||
| with: Organizations::AdoptablePetPolicy).ransack(params[:q]) | |||
| @q = authorized_scope(Pet.all, with: Organizations::AdoptablePetPolicy).ransack(params[:q]) | |||
There was a problem hiding this comment.
Do you think we should only return pets that are unadopted for this collection? We won't ever show adopted pets to adopter users here.
There was a problem hiding this comment.
Sure, I can do that. Okay if I add that to this PR?
There was a problem hiding this comment.
Added to this PR for now (see last commit).
There was a problem hiding this comment.
Yes in this PR is fine. Thanks.
🔗 Issue
#1021
✍️ Description
Pet#is_adopted?method to referenceMatchassociation rather thanAdopterApplication