Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing category dropdown on new item form #4712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

princekumarg12
Copy link
Contributor

Resolves #4674

Description

This change addresses the issue where the category dropdown disappears after submitting an invalid "New Item" form. The change ensures that the @item_categories variable is correctly populated even after an error occurs, allowing users to select a category without issues.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The following tests were conducted to verify the changes:

  1. Log in as an organization admin.
  2. Navigate to the "New Item" page.
  3. Attempt to save a blank form.
  4. Verify that the category dropdown remains accessible and functional after the error is triggered.

@princekumarg12
Copy link
Contributor Author

Fixes category dropdown disappearing after new item form error.

@cielf
Copy link
Collaborator

cielf commented Oct 9, 2024

Note: this is a PR on an issue that already had a PR on it.

@cielf
Copy link
Collaborator

cielf commented Oct 9, 2024

@princekumarg12 There was already a PR in progress for this one, so I think we'll go with that one, if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] On new item, category dropdown disappears after error
2 participants