Experiment with moving serialization out of Filter classes #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a FilterGroupBlueprint which dynamically determines whether to use a regular FilterOptionBlueprint or the special case ContributionTypeFilterOptionBlueprint. This allows us to extract serialization out of the Filter classes, leaving it appropriately in the controller -> serialization layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This allows us to extract serialization out of the Filter classes, leaving it appropriately in the controller -> serialization layer.
What
Introduces a
FilterGroupBlueprintwhich dynamically determines whether to use a regularFilterOptionBlueprintor the special caseContributionTypeFilterOptionBlueprint.Testing
Covered by existing tests.
Outstanding Questions, Concerns and Other Notes
?
Meta
@h-m-m , this came out of a pairing discussion we had many months ago. I remember spiking this out and found the branch lying around. Figured i'd bring it up to date and put up a PR. Totally happy to close this out though if this direction doesn't feel right.
Pre-Merge Checklist