Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace new volume control #657

Open
1 task
elynema opened this issue Oct 8, 2024 · 1 comment
Open
1 task

Replace new volume control #657

elynema opened this issue Oct 8, 2024 · 1 comment
Assignees

Comments

@elynema
Copy link

elynema commented Oct 8, 2024

Description

The new volume control button in Ramp that is shaped like a triangle does not allow for as easy adjustment of volume as the slider and does not provide a single click to mute/ un-mute.

Consider bringing back the vertical slider. We have numerous other widgets in Ramp that overlay the progress bar with a menu, so it seems like it could work for the vertical slider as well. Alternatively, all the popups that are used by widgets, including the vertical slider, could be placed above the progress bar.

Done Looks Like

  • Volume control component changed to the previous style: click to enable/disable with a slider overlay for the volume
@Dananji
Copy link
Collaborator

Dananji commented Oct 18, 2024

Note for testing:

  • All popup menus were moved to display above progress-control
  • All popup menus (captions, quality selection, file download, playback rate) are now displayed only on click/keydown (Enter/Space on focus, when using keyboard navigation) events. Previously these menus were shown on both click/keydown/hover event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants