New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace volume control with muteToggle/volumePanel, popup menus above progress-bar #669

Open

Dananji wants to merge 2 commits into main from volumepanel-657

Collaborator

Dananji commented Oct 17, 2024 •

edited

Loading

Related issue: #657

This PR includes the following changes;

Revert volume bar to the previous state where video players have vertical volume control and audio players have sticky horizontal volume control as follows.

Screenshot 2024-10-17 at 4 54 48 PM

Screenshot 2024-10-17 at 4 55 30 PM

Move all popup menus above the progress-control. As part of this work display of the popup menus on hover event on the buttons are removed. This seems to be the common practice in other platforms e.g. LinkedInLearning and YouTube.

Dananji added 2 commits

October 17, 2024 16:53


          Replace volume control with muteToggle/volumePanel, shift popup menus…

35227b3

… above progress-bar


          Only show popup menus on click/keydown events

752c882

Dananji marked this pull request as ready for review

October 18, 2024 18:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet