-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove linking unless explicitly enabling testing #31
base: master
Are you sure you want to change the base?
Conversation
Thanks, I really appreciate the amount of work you've put into researching the problem space and implementing a solution. It seems like a reasonable change (and also means that I can delete a bunch of static-related code from Thermite), unfortunately I don't have write access to either this or ruru, so I can't merge either PR. I would wait anyway until the tests are fixed in master. |
@d-unseductable in the meantime I believe I also fixed the travis tests. Basically the OS X images have |
Hrm, when I get some time I need to write a PR to replace travis-cargo (unmaintained, Python) with cargo-travis (maintained, Rust). |
I think this should be made configurable, since there is also a use case, where you want to run a ruby interpreter inside a rust program. |
@d-unseductable / @malept : So, here's my solution to the discussion in #25.
Basically the idea is to only pass the linkage to
libruby
when we buildruby-sys
with--features=test
. It's kind of ghetto that you have to actually feature-flag it, but it looks like that's the only way of really doing that in a build script as far as I can tell. Also, since you literally only need to linklibruby
when you would want to run Rust tests, I figure there's no real difference in just supporting dynamic linking.I'll also submit a PR for
ruru
to re-export the feature flag so that the Rust tests can still be run.