Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM: Preset loading async #29335

Draft
wants to merge 2 commits into
base: norbert/partial-core-esm-only
Choose a base branch
from

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 11, 2024

What I did

  • make all code in presets.ts (the preset loading mechanic) all async, including the code responsible for resolving from name

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.7 MB 78.7 MB 0 B - 0%
initSize 146 MB 146 MB 285 B Infinity 0%
diffSize 67.5 MB 67.5 MB 285 B Infinity 0%
buildSize 6.79 MB 6.79 MB 0 B - 0%
buildSbAddonsSize 1.5 MB 1.5 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.83 MB 1.83 MB 0 B - 0%
buildSbPreviewSize 270 kB 270 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.8 MB 3.8 MB 0 B - 0%
buildPreviewSize 2.99 MB 2.99 MB 0 B - 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 5.2s 22.7s 17.4s Infinity 🔺76.8%
generateTime 18.3s 18.6s 305ms Infinity 1.6%
initTime 11.9s 11.8s -121ms -Infinity -1%
buildTime 9.4s 11.5s 2.1s Infinity 🔺18.3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.1s 6.6s 493ms Infinity 🔺7.4%
devManagerResponsive 3.8s 4.1s 301ms Infinity 🔺7.3%
devManagerHeaderVisible 677ms 542ms -135ms -Infinity 🔰-24.9%
devManagerIndexVisible 705ms 573ms -132ms -Infinity 🔰-23%
devStoryVisibleUncached 871ms 705ms -166ms -Infinity 🔰-23.5%
devStoryVisible 703ms 575ms -128ms -Infinity 🔰-22.3%
devAutodocsVisible 579ms 423ms -156ms -Infinity 🔰-36.9%
devMDXVisible 560ms 455ms -105ms -Infinity 🔰-23.1%
buildManagerHeaderVisible 539ms 469ms -70ms -Infinity 🔰-14.9%
buildManagerIndexVisible 542ms 473ms -69ms -Infinity 🔰-14.6%
buildStoryVisible 589ms 501ms -88ms -Infinity 🔰-17.6%
buildAutodocsVisible 513ms 432ms -81ms -Infinity 🔰-18.7%
buildMDXVisible 581ms 426ms -155ms -Infinity 🔰-36.4%

@ndelangen ndelangen self-assigned this Oct 11, 2024
Copy link

nx-cloud bot commented Oct 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bedc050. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant