Addon-Test: Report component file tests to the frontend #29388
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 file(s) reviewed, 11 comment(s)
Edit PR Review Bot Settings | Greptile
| } else if (failed && !errorMessage) { | ||
| message = 'Component tests failed'; |
There was a problem hiding this comment.
logic: This condition might not cover all failure scenarios
| testResults: TestResult[]; | ||
| error?: { message: 'string'; name: 'string' }; |
There was a problem hiding this comment.
syntax: The 'string' type should not be in quotes
There was a problem hiding this comment.
@valentinpalkovic Looks like Greptile is correct. I would've totally overlooked it myself.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 204db5d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
valentinpalkovic
force-pushed
the
valentin/report-component-test-errors
branch
from
7cb691a
to
c04d44a
Compare
valentinpalkovic
force-pushed
the
valentin/report-component-test-errors
branch
from
c04d44a
to
204db5d
Compare
| testResults: TestResult[]; | ||
| error?: { message: 'string'; name: 'string' }; |
There was a problem hiding this comment.
@valentinpalkovic Looks like Greptile is correct. I would've totally overlooked it myself.
Closes N/A
What I did
I have changed the reporting mechanism for story files, which cannot be executed by Vitest. For example, if the preview.js file throws an error or a story file has issues to process an import and throws.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This pull request enhances error reporting and status updates for component tests in Storybook, focusing on improved handling of test failures and crashes.
TestingModuleCrashReportPayloadtype to include anerrorobject with amessagepropertyStorybookReporterclass to provide more detailed reporting of test suite failuresSidebarBottomcomponent to handle crash and progress reports more effectivelyboot-test-runner.tsfor better alignment with the new error reporting structurepreset.ts