-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Quest] How power line is attached on this support? #5382
base: master
Are you sure you want to change the base?
[Quest] How power line is attached on this support? #5382
Conversation
app/src/main/java/de/westnordost/streetcomplete/quests/power_attachment/AddPowerAttachment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/power_attachment/AddPowerAttachment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/power_attachment/PowerAttachmentItem.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/power_attachment/PowerAttachmentItem.kt
Outdated
Show resolved
Hide resolved
I still have serious doubts about value of collecting this data (like for |
app/src/main/java/de/westnordost/streetcomplete/quests/power_attachment/AddPowerAttachment.kt
Show resolved
Hide resolved
b7f38cb
to
b64d9e0
Compare
8d48ce3
to
e1f8618
Compare
@flacombe any news? |
e1f8618
to
018962c
Compare
018962c
to
79ec4cb
Compare
I want finish this PR |
At desktop they do seem recognizable to me, but I'm not sure how they'd look scaled down to just a small part of (already small) mobile phone screen. Although looking at thumbnails at https://wiki.openstreetmap.org/wiki/Key:line_attachment they might probably be fine. |
Theoretically yes, I think, after all the picture could be cropped a little to focus on what's important. (But need to try it out.) Also, it would be preferable if anything but the supports was about the same on the pictures, i.e. similar sky background, similar perspective. |
I have found better examples with good quality: I continue to search an example for line_attachment=pin @flacombe any suggestions? |
79ec4cb
to
855bf3e
Compare
@westnordost do you think is enough recognizable? |
Hello @Jean-BaptisteC and thank you for pictures. To me it's all good and recognizable. |
The difference is definitely recognizable. The first are some UFOs, the other are some springs. It's also nice that everything else about the pics is similar (the sky, the kind of pole), it highlights the differences. |
Fixes #4825
Todo: