Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Instant Debits in deferred intent flows #9439

Draft
wants to merge 2 commits into
base: tillh/instant-debits-billing-details
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-deferred-intent branch from 2645d3d to 6124db3 Compare October 11, 2024 20:12
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │     4 MiB │     4 MiB │ +2.3 KiB │   8.7 MiB │   8.7 MiB │ +3.2 KiB 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │   2.3 MiB │   2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │  25.6 KiB │  25.6 KiB │      0 B 
      res │ 933.8 KiB │ 933.8 KiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │   2.9 MiB │   2.9 MiB │    +23 B │   2.9 MiB │   2.9 MiB │    +23 B 
    other │ 200.7 KiB │ 200.7 KiB │     +9 B │ 442.2 KiB │ 442.2 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.9 MiB │  12.9 MiB │ +2.3 KiB │  21.9 MiB │  21.9 MiB │ +3.2 KiB 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 42478 │ 42489 │ +11 (+66 -55)     
   types │ 14264 │ 14265 │  +1 (+48 -47)     
 classes │ 11874 │ 11873 │  -1 (+7 -8)       
 methods │ 61039 │ 61042 │  +3 (+1216 -1213) 
  fields │ 40267 │ 40282 │ +15 (+1013 -998)  

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6269 │ 6269 │  0
APK
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
    4 MiB │ +2.3 KiB │   8.7 MiB │ +3.2 KiB │ ∆ classes.dex                             
    8 KiB │    +18 B │   7.9 KiB │    +18 B │ ∆ assets/dexopt/baseline.prof             
 50.3 KiB │     +6 B │ 118.5 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
  1,023 B │     +5 B │     891 B │     +5 B │ ∆ assets/dexopt/baseline.profm            
 53.5 KiB │     +4 B │ 118.6 KiB │      0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │     -2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
    272 B │     +1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  4.1 MiB │ +2.3 KiB │   8.9 MiB │ +3.2 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   42478 │ 42489 │ +11 (+66 -55) 
  
  + , billingAddress=
  + , billingEmailAddress=
  + , city=
  + , encodedPaymentMethod=
  + Address(line1=
  + BillingAddress(name=
  + Consumer session email address cannot be null
  + InstantDebitsData(paymentMethod=
  + InstantDebitsInfo(paymentMethod=
  + InstantDebitsResult(paymentMethod=
  + LI5/K;
  + LI5/L;
  + LW4/h;
  + Lc7/j;
  + Lj7/n;
  + Lr7/Q;
  + Ly1/n;
  + PaymentMethod(paymentMethod=
  + [LI5/f;
  + [LI5/i;
  + [LI5/p;
  + [LI5/t;
  + [LI5/w;
  + [LP7/H;
  + [LW4/f;
  + [LW7/j;
  + [LW7/q;
  + [La7/B0;
  + [La7/N2;
  + [La7/e2;
  + [La7/s1;
  + [La7/y;
  + [Lc7/i;
  + [Lcom/google/android/material/datepicker/d;
  + [Lcom/google/android/material/datepicker/m;
  + [Li7/j;
  + [Lk9/C1;
  + [Lk9/M0;
  + [Lk9/c1;
  + [Lk9/j1;
  + [Lk9/m0;
  + [Lk9/p1;
  + [Lk9/r1;
  + [Lk9/t0;
  + [Lk9/y0;
  + [Ln6/F2;
  + [Ln6/I;
  + [Ln6/L;
  + [Ln6/a3;
  + [Ln6/s2;
  + [Ln6/w2;
  + [Ln8/O;
  + [Ln8/Q;
  + [Lr7/s;
  + [Ls8/A;
  + [Ls8/C;
  + [Ls8/y;
  + [Lx3/n;
  + [Ly7/Q;
  + administrative_area
  + billingEmailAddress
  + billing_phone
  + encodedPaymentMethod
  + line_1
  + line_2
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"b0d6388","r8-mode":"full","version":"8.5.35"}
  
  - An operation is not implemented: Instant Debits do not support deferred payments yet
  - Completed(paymentMethodId=
  - InstantDebitsData(paymentMethodId=
  - InstantDebitsInfo(paymentMethodId=
  - InstantDebitsResult(paymentMethodId=
  - LW7/F;
  - Lcom/google/android/material/datepicker/x;
  - Lk9/E1;
  - Ln6/b3;
  - Ln6/c3;
  - Ln6/d3;
  - Ls8/P;
  - Ly7/V;
  - StripeIntent not set for this session
  - [LI5/m;
  - [LI5/n;
  - [LI5/r;
  - [LP7/F;
  - [LW4/d;
  - [LW7/k;
  - [LW7/r;
  - [La7/A0;
  - [La7/L2;
  - [La7/c2;
  - [La7/p1;
  - [La7/w;
  - [Lc7/h;
  - [Lcom/google/android/material/datepicker/e;
  - [Lcom/google/android/material/datepicker/n;
  - [Li7/i;
  - [Lk9/D1;
  - [Lk9/O0;
  - [Lk9/e1;
  - [Lk9/k1;
  - [Lk9/n0;
  - [Lk9/q1;
  - [Lk9/s1;
  - [Lk9/u0;
  - [Lk9/z0;
  - [Ln6/C2;
  - [Ln6/H;
  - [Ln6/K;
  - [Ln6/O2;
  - [Ln6/d3;
  - [Ln6/q2;
  - [Ln8/N;
  - [Ln8/P;
  - [Lr7/r;
  - [Ls8/B;
  - [Ls8/G;
  - [Ls8/z;
  - [Lx3/l;
  - [Ly7/T;
  - com.stripe.android.financialconnections.model.PaymentMethod
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"92d3ed4","r8-mode":"full","version":"8.5.35"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   14264 │ 14265 │ +1 (+48 -47) 
  
  + LI5/K;
  + LI5/L;
  + LW4/h;
  + Lc7/j;
  + Lj7/n;
  + Lr7/Q;
  + Ly1/n;
  + [LI5/f;
  + [LI5/i;
  + [LI5/p;
  + [LI5/t;
  + [LI5/w;
  + [LP7/H;
  + [LW4/f;
  + [LW7/j;
  + [LW7/q;
  + [La7/B0;
  + [La7/N2;
  + [La7/e2;
  + [La7/s1;
  + [La7/y;
  + [Lc7/i;
  + [Lcom/google/android/material/datepicker/d;
  + [Lcom/google/android/material/datepicker/m;
  + [Li7/j;
  + [Lk9/C1;
  + [Lk9/M0;
  + [Lk9/c1;
  + [Lk9/j1;
  + [Lk9/m0;
  + [Lk9/p1;
  + [Lk9/r1;
  + [Lk9/t0;
  + [Lk9/y0;
  + [Ln6/F2;
  + [Ln6/I;
  + [Ln6/L;
  + [Ln6/a3;
  + [Ln6/s2;
  + [Ln6/w2;
  + [Ln8/O;
  + [Ln8/Q;
  + [Lr7/s;
  + [Ls8/A;
  + [Ls8/C;
  + [Ls8/y;
  + [Lx3/n;
  + [Ly7/Q;
  
  - LW7/F;
  - Lcom/google/android/material/datepicker/x;
  - Lk9/E1;
  - Ln6/b3;
  - Ln6/c3;
  - Ln6/d3;
  - Ls8/P;
  - Ly7/V;
  - [LI5/m;
  - [LI5/n;
  - [LI5/r;
  - [LP7/F;
  - [LW4/d;
  - [LW7/k;
  - [LW7/r;
  - [La7/A0;
  - [La7/L2;
  - [La7/c2;
  - [La7/p1;
  - [La7/w;
  - [Lc7/h;
  - [Lcom/google/android/material/datepicker/e;
  - [Lcom/google/android/material/datepicker/n;
  - [Li7/i;
  - [Lk9/D1;
  - [Lk9/O0;
  - [Lk9/e1;
  - [Lk9/k1;
  - [Lk9/n0;
  - [Lk9/q1;
  - [Lk9/s1;
  - [Lk9/u0;
  - [Lk9/z0;
  - [Ln6/C2;
  - [Ln6/H;
  - [Ln6/K;
  - [Ln6/O2;
  - [Ln6/d3;
  - [Ln6/q2;
  - [Ln8/N;
  - [Ln8/P;
  - [Lr7/r;
  - [Ls8/B;
  - [Ls8/G;
  - [Ls8/z;
  - [Lx3/l;
  - [Ly7/T;
  

METHODS:

   old   │ new   │ diff             
  ───────┼───────┼──────────────────
   61039 │ 61042 │ +3 (+1216 -1213) 
  
  + A7.A <init>(Context, k1, J, Object, Set, Y0)
  + B5.P <init>(q, c, I, f, a, i)
  + B5.t <init>(P, I)
  + B7.A h(Object, G1, S, p0)
  + B7.A j(Object, o, Q, m0)
  + B7.B h(Object, G1, S, p0)
  + B7.B j(Object, o, Q, m0)
  + B7.D h(Object, G1, S, p0)
  + B7.D j(Object, o, Q, m0)
  + B7.F h(Object, G1, S, p0)
  + B7.F j(Object, o, Q, m0)
  + B7.K h(Object, G1, S, p
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-deferred-intent branch 3 times, most recently from 58cdffb to 25cdd8b Compare October 17, 2024 20:00
@tillh-stripe tillh-stripe changed the base branch from master to tillh/instant-debits-billing-details October 17, 2024 20:01
@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-billing-details branch from 7396227 to 74c3f3b Compare October 17, 2024 20:31
@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-deferred-intent branch 2 times, most recently from 9434fb3 to e1248a7 Compare October 18, 2024 15:07
@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-billing-details branch 3 times, most recently from 799f952 to e09b969 Compare October 18, 2024 19:20
@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-deferred-intent branch from e1248a7 to fe9a2ee Compare October 18, 2024 20:31
@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-deferred-intent branch from fe9a2ee to fc97139 Compare October 18, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant