Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚫 DO NOT MERGE] [Connect] Prepare to publish StripeConnect module #4035

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mludowise-stripe
Copy link
Collaborator

@mludowise-stripe mludowise-stripe commented Sep 23, 2024

Standing up WIP branch with published package so we can test building against this in the Dashboard app. This will not be merged until we're ready to publish the SDK.

TODO

  • Verify docs generation
  • README
  • CHANGELOG

Summary

Added StripeConnect to package managers and installation tests in preparation for release.

Motivation

https://jira.corp.stripe.com/browse/MXMOBILE-2496

Testing

Changelog

@mludowise-stripe mludowise-stripe changed the title Mludowise/mxmobile 2496 connect package configs [🚫 DO NOT MERGE] [Connect] Prepare to publish StripeConnect module Sep 23, 2024
@mludowise-stripe mludowise-stripe changed the base branch from master to mludowise/MXMOBILE-2502_uk_connect September 23, 2024 02:57
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch from 5fca70e to ca120b7 Compare September 23, 2024 03:12
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 4 times, most recently from 5bbf80d to 80135ce Compare September 23, 2024 06:30
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch from 80135ce to dc140d2 Compare September 24, 2024 01:04
Base automatically changed from mludowise/MXMOBILE-2502_uk_connect to master September 24, 2024 03:12
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 2 times, most recently from 7ee34cb to 00d6102 Compare September 26, 2024 06:32
@mludowise-stripe mludowise-stripe changed the base branch from master to mludowise/MXMOBILE-2503_notification_banner September 26, 2024 06:35
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 2 times, most recently from 8a68f14 to 60a910a Compare September 26, 2024 22:45
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2503_notification_banner branch 3 times, most recently from baf7731 to c04f948 Compare September 29, 2024 00:18
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch 2 times, most recently from 97bb385 to df4771b Compare September 29, 2024 00:36
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2503_notification_banner branch from 6f39d37 to 19b7736 Compare October 2, 2024 19:37
@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2496_connect_package_configs branch from df4771b to 60a80a3 Compare October 3, 2024 03:07
Copy link

emerge-tools bot commented Oct 3, 2024

⚠️ 5 new unused protocols, 6 builds decreased size

Name Version Download Change Install Change Approval
StripeSize
com.stripe.StripeSize
1.0 (1) 2.4 MB ⬇️ 3.6 kB (-0.15%) 7.8 MB ⬇️ 11.1 kB (-0.14%) N/A
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 433.2 kB ⬇️ 1.4 kB (-0.32%) 1.5 MB ⬇️ 3.1 kB (-0.21%) N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 1.3 MB ⬇️ 3.1 kB (-0.24%) 4.3 MB ⬇️ 5.9 kB (-0.14%) N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 1.1 MB ⬇️ 3.4 kB (-0.29%) 4.1 MB ⬇️ 5.1 kB (-0.13%) N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 1.9 MB ⬇️ 3.1 kB (-0.17%) 6.3 MB ⬇️ 6.9 kB (-0.11%) N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 3.4 MB ⬇️ 8.8 kB (-0.26%) 10.2 MB ⬇️ 24.9 kB (-0.24%) N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

⚠️ Found new unused protocol: InstantDebitsLinkedBank
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 11.1 kB (-0.14%)
Total download size change: ⬇️ 3.6 kB (-0.15%)

Largest size changes

Item Install Size Change
StripePayments.STPBankAccountCollector.collectBankAccountForSetup... ⬇️ -1.5 kB
StripeUICore.TextFieldElement.BlikCodeConfiguration.value witness ⬇️ -1.1 kB
DYLD.Exports ⬇️ -928 B
StripePayments.STPBankAccountCollector.collectBankAccountForPayme... ⬇️ -844 B
🗑 StripeCore.FinancialConnectionsLinkedBank.value witness ⬇️ -740 B
View Treemap

Image of diff

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

⚠️ Found new unused protocol: InstantDebitsLinkedBank
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 3.1 kB (-0.21%)
Total download size change: ⬇️ 1.4 kB (-0.32%)

Largest size changes

Item Install Size Change
🗑 StripeCore.FinancialConnectionsLinkedBank.value witness ⬇️ -740 B
DYLD.Exports ⬇️ -712 B
🗑 StripeCore.InstantDebitsLinkedBank.value witness ⬇️ -552 B
Other ⬇️ -1.1 kB
View Treemap

Image of diff

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

⚠️ Found new unused protocol: InstantDebitsLinkedBank
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 5.9 kB (-0.14%)
Total download size change: ⬇️ 3.1 kB (-0.24%)

Largest size changes

Item Install Size Change
StripeFinancialConnections.FinancialConnectionsWebFlowViewControl... ⬇️ -1.4 kB
🗑 StripeFinancialConnections.Completed ⬇️ -1.4 kB
🗑 StripeFinancialConnections.HostControllerResult.HostControllerRes... ⬇️ -1.3 kB
StripeUICore.TextFieldElement.BlikCodeConfiguration.value witness ⬇️ -1.1 kB
StripeFinancialConnections.FinancialConnectionsWebFlowViewControl... ⬆️ 964 B
View Treemap

Image of diff

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

⚠️ Found new unused protocol: InstantDebitsLinkedBank
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 5.1 kB (-0.13%)
Total download size change: ⬇️ 3.4 kB (-0.29%)

Largest size changes

Item Install Size Change
StripePayments.STPBankAccountCollector.collectBankAccountForSetup... ⬇️ -1.5 kB
StripePayments.STPBankAccountCollector.collectBankAccountForPayme... ⬇️ -844 B
🗑 StripeCore.FinancialConnectionsLinkedBank.value witness ⬇️ -740 B
📝 StripePayments.StubbedFinancialConnectionsLinkedBank.value witnes... ⬆️ 740 B
DYLD.Exports ⬇️ -720 B
View Treemap

Image of diff

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

⚠️ 2 new unused protocols: InstantDebitsLinkedBank and FinancialConnectionsLinkedBank
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 6.9 kB (-0.11%)
Total download size change: ⬇️ 3.1 kB (-0.17%)

Largest size changes

Item Install Size Change
StripePayments.STPBankAccountCollector.collectBankAccountForSetup... ⬇️ -1.5 kB
StripeUICore.TextFieldElement.BlikCodeConfiguration.value witness ⬇️ -1.1 kB
DYLD.Exports ⬇️ -960 B
StripePayments.STPBankAccountCollector.collectBankAccountForPayme... ⬇️ -844 B
🗑 StripeCore.FinancialConnectionsLinkedBank.value witness ⬇️ -740 B
View Treemap

Image of diff

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 24.9 kB (-0.24%)
Total download size change: ⬇️ 8.8 kB (-0.26%)

Largest size changes

Item Install Size Change
📝 StripePaymentSheet.EmbeddedPaymentElement.Configuration.makePayme... ⬆️ 5.0 kB
📝 StripePaymentSheet.USBankAccountPaymentMethodElement.init(configu... ⬆️ 4.0 kB
🗑 StripePaymentSheet.PaymentSheetVerticalViewController.makeWalletH... ⬇️ -3.8 kB
🗑 StripePaymentSheet.PaymentElementConfiguration ⬇️ -3.7 kB
StripePaymentSheet.PaymentSheetVerticalViewController.init(config... ⬇️ -3.2 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Copy link

github-actions bot commented Oct 3, 2024

🚨 New dead code detected in this PR:

ConnectWebView.swift: warning: Function 'showErrorAlert(for:)' is unused
ConnectWebView.swift: warning: Function 'download(decideDestinationUsing:suggestedFilename:)' is unused
ConnectWebView.swift: warning: Function 'download(didFailWithError:resumeData:)' is unused
ConnectWebView.swift: warning: Function 'downloadDidFinish()' is unused
ConnectWebView.swift: warning: Function 'download(_:decideDestinationUsing:suggestedFilename:)' is unused
ConnectWebView.swift: warning: Function 'download(_:didFailWithError:resumeData:)' is unused
ConnectWebView.swift: warning: Function 'downloadDidFinish(_:)' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@mludowise-stripe mludowise-stripe force-pushed the mludowise/MXMOBILE-2503_notification_banner branch from 0c10880 to bb8a81d Compare October 4, 2024 21:29
Base automatically changed from mludowise/MXMOBILE-2503_notification_banner to master October 4, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant