Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing transparent nav bar in 3DS SDK #4108

Open
wants to merge 2 commits into
base: feature/2.2
Choose a base branch
from
Open

Conversation

Pearapps
Copy link
Collaborator

@Pearapps Pearapps commented Oct 8, 2024

Fixes transparent navigation bar by allowing configuration of the scrollEdgeAppearance.

image

Copy link

emerge-tools bot commented Oct 8, 2024

6 builds decreased size

Name Version Download Change Install Change Approval
StripeSize
com.stripe.StripeSize
1.0 (1) 2.4 MB ⬇️ 1.7 kB (-0.07%) 7.8 MB ⬇️ 5.4 kB (-0.07%) N/A
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 435.1 kB ⬇️ 2.3 kB (-0.52%) 1.5 MB ⬇️ 8.4 kB (-0.56%) N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 1.3 MB ⬇️ 4.7 kB (-0.36%) 4.3 MB ⬇️ 8.5 kB (-0.2%) N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 1.1 MB ⬇️ 745 B (-0.06%) 4.1 MB ⬇️ 3.7 kB (-0.09%) N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 1.9 MB ⬆️ 33 B 6.3 MB ⬇️ 5.4 kB (-0.09%) N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 3.4 MB ⬇️ 11.9 kB (-0.35%) 10.2 MB ⬇️ 26.6 kB (-0.26%) N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 5.4 kB (-0.07%)
Total download size change: ⬇️ 1.7 kB (-0.07%)

Largest size changes

Item Install Size Change
Localizable.strings ⬇️ -4.1 kB
🗑 StripeCore.Locale.toLanguageTag ⬇️ -1.4 kB
📝 STDSChallengeResponseViewController.submit: ⬆️ 928 B
🗑 StripeUICore.AddressSpecProvider.AddressSpecProvider ⬇️ -896 B
🗑 StripeUICore.BSBNumberProvider.BSBNumberProvider ⬇️ -824 B
View Treemap

Image of diff

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 8.4 kB (-0.56%)
Total download size change: ⬇️ 2.3 kB (-0.52%)

Largest size changes

Item Install Size Change
🗑 StripeCore.Locale.toLanguageTag ⬇️ -1.4 kB
StripeCore.ElementsSessionContext.value witness ⬇️ -604 B
🗑 StripeCore.ElementsSessionContext.IntentID ⬇️ -577 B
Other ⬇️ -5.8 kB
View Treemap

Image of diff

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 8.5 kB (-0.2%)
Total download size change: ⬇️ 4.7 kB (-0.36%)

Largest size changes

Item Install Size Change
🗑 StripeFinancialConnections.FinancialConnectionsAPIClient.linkAcco... ⬇️ -1.7 kB
🗑 StripeCore.Locale.toLanguageTag ⬇️ -1.4 kB
📝 StripeFinancialConnections.FinancialConnectionsAPIClient.linkAcco... ⬆️ 956 B
🗑 StripeUICore.AddressSpecProvider.AddressSpecProvider ⬇️ -896 B
🗑 StripeUICore.BSBNumberProvider.BSBNumberProvider ⬇️ -884 B
View Treemap

Image of diff

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 3.7 kB (-0.09%)
Total download size change: ⬇️ 745 B (-0.06%)

Largest size changes

Item Install Size Change
🗑 StripeCore.Locale.toLanguageTag ⬇️ -1.4 kB
📝 STDSChallengeResponseViewController.submit: ⬆️ 928 B
External Methods ⬆️ 710 B
STDSChallengeResponseViewController._actionButtonTapped: ⬇️ -616 B
📝 STDSTransaction.initWithDeviceInformation:directoryServerID:serve... ⬆️ 604 B
View Treemap

Image of diff

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 5.4 kB (-0.09%)
Total download size change: ⬆️ 33 B

Largest size changes

Item Install Size Change
Localizable.strings ⬇️ -4.1 kB
🗑 StripeCore.Locale.toLanguageTag ⬇️ -1.4 kB
📝 STDSChallengeResponseViewController.submit: ⬆️ 928 B
🗑 StripeUICore.AddressSpecProvider.AddressSpecProvider ⬇️ -896 B
🗑 StripeUICore.BSBNumberProvider.BSBNumberProvider ⬇️ -884 B
View Treemap

Image of diff

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 26.6 kB (-0.26%)
Total download size change: ⬇️ 11.9 kB (-0.35%)

Largest size changes

Item Install Size Change
🗑 StripePaymentSheet.CardSectionElement.init(collectName,defaultVal... ⬇️ -8.1 kB
📝 StripePaymentSheet.CardSectionElement.init(collectName,defaultVal... ⬆️ 8.1 kB
📝 StripePaymentSheet.EmbeddedPaymentMethodsView.init(initialSelecti... ⬆️ 7.6 kB
🗑 StripePaymentSheet.EmbeddedPaymentMethodsView.init(initialSelecti... ⬇️ -6.1 kB
Localizable.strings ⬇️ -4.1 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

@Pearapps Pearapps marked this pull request as ready for review October 17, 2024 15:07
@Pearapps Pearapps requested review from a team as code owners October 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants