Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter card brands in Apple Pay and CBC #4131

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Oct 11, 2024

Summary

  • Passes the accepted card brands into Apple Pay
  • Properly filters card brands for CBC
  • Hides cards of disallowed brands in CustomerSheet (CustomerSession & CustomerAdapter)

Apple Pay

Allow all

Simulator Screenshot - Snapshot - 2024-10-11 at 09 19 31

Disallow Amex

Simulator Screenshot - Snapshot - 2024-10-11 at 09 19 49

Allow only Visa

Simulator Screenshot - Snapshot - 2024-10-11 at 09 20 03

CBC

Allow all

allowAll.mp4

Allow only Visa (Don't show CB)

allowed_visa.mp4

Disallow Visa (auto select CB)

disallowed_visa.mp4

Motivation

  • CBF

Testing

  • Manual
  • New unit tests

Changelog

N/A

Base automatically changed from porter/cbf-api-add to master October 15, 2024 18:01
Copy link

emerge-tools bot commented Oct 15, 2024

📸 Snapshot Test

No snapshots generated

Name Version Added Removed Modified Unchanged Errored Approval
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 0 0 0 0 0 N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 0 0 0 0 0 N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 0 0 0 0 0 N/A
StripeSize
com.stripe.StripeSize
1.0 (1) 0 0 0 0 0 N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 0 0 0 0 0 N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 0 0 0 0 0 N/A

🛸 Powered by Emerge Tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant