-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BANKCON-15711] Pass billing address and email address to payment details API #4148
base: master
Are you sure you want to change the base?
Conversation
} | ||
|
||
if let billingEmail, !billingEmail.isEmpty { | ||
parameters["billing_email_address"] = billingEmail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case name | ||
case line1 = "line_1" | ||
case line2 = "line_2" | ||
case city = "locality" | ||
case state = "administrative_area" | ||
case postalCode = "postal_code" | ||
case countryCode = "country_code" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 New dead code detected in this PR: FinancialConnectionsAPIClient.swift:246 warning: Function 'paymentDetails(consumerSessionClientSecret:bankAccountId:billingAddress:billingEmail:)' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
905cca9
to
dd16f78
Compare
StripePaymentSheet- public var paymentMethodLayout: StripePaymentSheet.PaymentSheet.PaymentMethodLayout
- public enum PaymentMethodLayout {
- case horizontal
- case vertical
- case automatic
- public static func == (a: StripePaymentSheet.PaymentSheet.PaymentMethodLayout, b: StripePaymentSheet.PaymentSheet.PaymentMethodLayout) -> Swift.Bool
- public func hash(into hasher: inout Swift.Hasher)
- public var hashValue: Swift.Int {
- get
- }
- } If you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
Android equivalent: stripe/stripe-android#9446
Summary
This passes the billing address model and a billing email to the
/consumers/payment_details/
API. More details: https://docs.google.com/document/d/1IP66DkxVK6DzeGCmuw00Gt9okFhEHQgM3lqBZSA-M4E/edit?usp=sharingNote
There is currently a bug where the billing address is not being backfilled when using an existing Link account. This is being looked into (Slack), and can most likely be fixed with a backend change.
Motivation
BANKCON-15711
Testing
Unit tests, and I've verified the billing fields are correctly passed from MPE to the API call:
Changelog
N/a