Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requested billing address fields in Instant Debits bank tab #4162

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mats-stripe
Copy link
Collaborator

@mats-stripe mats-stripe commented Oct 18, 2024

Summary

This adds the name, phoneNumber, and address fields / sections in the MPE Bank tab, if they are included as part of the merchant configuration. The email field will always be shown, even when the configuration specifies to never collect an email, if no email is provided in the default billing details.

Motivation

Respect the merchant's configuration!

Testing

Plenty of unit tests, and some manual testing:

Configuration Screenshot
Automatic
Always or Full
Never, no defaults
Never, default email

Changelog

N/a

@mats-stripe mats-stripe marked this pull request as ready for review October 18, 2024 19:34
@mats-stripe mats-stripe requested review from a team as code owners October 18, 2024 19:34
Copy link

🚨 New dead code detected in this PR:

InstantDebitsPaymentMethodElement.swift:106 warning: Property 'defaultAddress' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@mats-stripe
Copy link
Collaborator Author

Testing:

Screen.Recording.2024-10-18.at.3.35.10.PM.mov

@mats-stripe
Copy link
Collaborator Author

🚨 New dead code detected in this PR:
InstantDebitsPaymentMethodElement.swift:106 warning: Property 'defaultAddress' is unused

It's true this field isn't being used in InstantDebitsPaymentMethodElement, but it's being referenced in tests for now, and will eventually be passed to the payment details API when attachDefaultBillingDetails is set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant