Skip to content

Commit

Permalink
Re-add extra empty line on Dockerfile-alpine
Browse files Browse the repository at this point in the history
  • Loading branch information
rafaelgaspar committed Sep 13, 2022
1 parent 6f4f466 commit 1461507
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions public-docker-images/Dockerfile-alpine
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ RUN GOOS=$TARGETOS GOARCH=$TARGETARCH CGO_ENABLED=0 go build -a -ldflags "-X git
GOOS=$TARGETOS GOARCH=$TARGETARCH CGO_ENABLED=0 go build -a -o /build/veneur-prometheus ./cmd/veneur-prometheus &&\
GOOS=$TARGETOS GOARCH=$TARGETARCH CGO_ENABLED=0 go build -a -ldflags "-X github.com/stripe/veneur/v14/util/build.VERSION=${VERSION} -X github.com/stripe/veneur/v14/util/build.BUILD_DATE=$(date +%s)" -o /build/veneur-proxy ./cmd/veneur-proxy


FROM alpine:3.16 AS release
LABEL maintainer="The Stripe Observability Team <[email protected]>"
RUN apk add --no-cache ca-certificates
Expand Down
4 changes: 2 additions & 2 deletions public-docker-images/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ You should run these commands from the project root.
For the Debian-based image:

```
docker buildx build --platform=linux/amd64,linux/arm64 --build-arg=VERSION=$(git rev-parse HEAD) --no-cache -t veneur:local -f public-docker-images/Dockerfile-debian-sid --output tar . | docker import -
docker buildx build --platform=linux/amd64,linux/arm64 --build-arg=VERSION=$(git rev-parse HEAD) --no-cache -t veneur:local -f public-docker-images/Dockerfile-debian-sid --output=tar . | docker import -
```

For the Alpine Linux-based image:

```
docker buildx build --platform=linux/amd64,linux/arm64 --build-arg=VERSION=$(git rev-parse HEAD) --no-cache -t veneur:local -f public-docker-images/Dockerfile-alpine --output tar . | docker import -
docker buildx build --platform=linux/amd64,linux/arm64 --build-arg=VERSION=$(git rev-parse HEAD) --no-cache -t veneur:local -f public-docker-images/Dockerfile-alpine --output=tar . | docker import -
```

For both cases you could remove ```--platform` arugment if you just plan build for the host architechture.
Expand Down

0 comments on commit 1461507

Please sign in to comment.