Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, unnecessary ActionButton render #588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Quintis1212
Copy link

Hello everyone ) I made a little refactor for AppSidebar component . I pass props from TakeNoteApp to AppSidebar directly , so AppSidebar does not call useSelector and recive props from parent. Also I discovered that ActionButton re-renders after every click on menu or on text changing in note. I decided to prevent unnecessary re-renders of ActionButton with PureComponent and children props. Please feel free to comment on how we can make it better

@Quintis1212
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant