Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check also for initcontianers in ShouldReap #92

Merged
merged 1 commit into from
Mar 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# pod-reaper: kills pods dead

### 2.13.0
- the reaper checks now also the initContainerStatus

### 2.7.0
- add `DRY_RUN` mode

Expand Down
10 changes: 10 additions & 0 deletions rules/container_status.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,16 @@ func (rule *containerStatus) ShouldReap(pod v1.Pod) (bool, string) {
return true, fmt.Sprintf("has container status %s", reapStatus)
}
}

// Check init containers
for _, initContainerStatus := range pod.Status.InitContainerStatuses {
state := initContainerStatus.State
// Check both waiting and terminated conditions for init containers
if (state.Waiting != nil && state.Waiting.Reason == reapStatus) ||
(state.Terminated != nil && state.Terminated.Reason == reapStatus) {
return true, fmt.Sprintf("has init container status %s", reapStatus)
}
}
}
return false, ""
}
Loading