Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firebase config values #15

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/api/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ import { getAuth } from 'firebase/auth';

// Your web app's Firebase configuration
const firebaseConfig = {
apiKey: 'FILL_ME_IN',
authDomain: 'FILL_ME_IN',
projectId: 'FILL_ME_IN',
storageBucket: 'FILL_ME_IN',
messagingSenderId: 'FILL_ME_IN',
appId: 'FILL_ME_IN',
apiKey: 'AIzaSyC7Va6r7PL9JZrTz8jn1Lwqwr_yhSAs2do',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we supposed to have an api key in this file?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've generally left it in this file since the key usually expired after a certain period anyway (90 days I think)

authDomain: 'tcl-76-smart-shopping-list.firebaseapp.com',
projectId: 'tcl-76-smart-shopping-list',
storageBucket: 'tcl-76-smart-shopping-list.appspot.com',
messagingSenderId: '283403874585',
appId: '1:283403874585:web:ec2053accd744733f51588',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO-DO: Make sure team has access to firebase. ✨

};

// Initialize Firebase
Expand Down