Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefinitionProxy#method_missing: Forward given block to #association #1579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grekko
Copy link

@grekko grekko commented Jun 13, 2023

Replacement for the prematurely closed PR #1518

Why:

When defining an association the block-argument will be ignored when also providing a factory-key on the association definition.

This behaviour might be unexpected, so we should raise an error that the passed block is unexpected/ignored.

Fixes thoughtbot#1503

Why:
----
When defining an association the block-argument will be ignored when also
providing a `factory`-key on the association definition.

This behaviour might be unexpected, so we should raise an error that the
passed block is unexpected/ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant