Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit CI runner version #2996

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Explicit CI runner version #2996

merged 3 commits into from
Oct 18, 2024

Conversation

mladedav
Copy link
Collaborator

@mladedav mladedav commented Oct 18, 2024

Motivation

Comment with context

We are currently using ubuntu-latest runners which may change and usually do change every two years. This can lead to issues as in #2994 where caches can be reused in a different version of ubuntu which can then break linking.

Solution

We set the runner version explicitly. This does not prevent similar issue as in the linked PR, but it will happen in the PR that upgrades the runner instead of random other PR that happened to run actions after the change.

I've also included the ubuntu-24.04 string in the cache key so that the issue doesn't happen again. This makes migration harder because this should be changed when a runner changes and I have not found a good way to deduplicate this because of this issue. But if both strings are correct, we will never use cache with objects built with older libraries.

@jplatte
Copy link
Member

jplatte commented Oct 18, 2024

Small nitpick: Commit messages should start in uppercase (after the optional prefix:).

@mladedav
Copy link
Collaborator Author

Ok. I know they should normally start with upper case, but it seemed to me it's usually not done after the prefix. For example conventional commits don't do it either in their examples. But I don't mind either way and I'll try to keep it in mind and use upper case here.

@mladedav mladedav merged commit 89fec69 into tokio-rs:main Oct 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants