-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(certificateResolvers)!: 💥 🐛 use same syntax in Chart and in Traefik #1214
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6469b11
feat(certificateResolvers)\!: :boom: use same syntax in Chart and in …
mloiseleur 7e11558
self-review: ensure certResolvers is not used anymore
mloiseleur 6bc694f
refacto: replace custom function with join
mloiseleur f445fbf
refacto: remove useless last else case
mloiseleur 77b909e
Apply suggestions from code review
mloiseleur 119519c
Apply suggestions from code review
mloiseleur 18fbb98
review
mloiseleur b0cc452
review
mloiseleur cdf6210
review
mloiseleur 3f61520
Update traefik/templates/_podtemplate.tpl
mloiseleur b5de2e2
fix
mloiseleur 1304326
fix indent
mloiseleur 49c2d59
fix: add quotes
darkweaver87 ea24c82
Merge branch 'master' into feat/cert-resolvers
darkweaver87 6d3031d
Merge remote-tracking branch 'upstream/master' into feat/cert-resolvers
traefiker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -330,15 +330,16 @@ tests: | |
content: "--experimental.kubernetesgateway" | ||
- it: should have the certificate resolver options applied | ||
set: | ||
certResolvers: | ||
certificatesResolvers: | ||
myAcmeResolver: | ||
email: [email protected] | ||
dnsChallenge: | ||
provider: myProvider | ||
resolvers: | ||
- 1.1.1.1 | ||
- 8.8.8.8 | ||
tlsChallenge: true | ||
acme: | ||
email: [email protected] | ||
dnsChallenge: | ||
provider: myProvider | ||
resolvers: | ||
- 1.1.1.1 | ||
- 8.8.8.8 | ||
tlsChallenge: true | ||
asserts: | ||
- contains: | ||
path: spec.template.spec.containers[0].args | ||
|
@@ -352,6 +353,38 @@ tests: | |
- contains: | ||
path: spec.template.spec.containers[0].args | ||
content: "--certificatesresolvers.myAcmeResolver.acme.tlsChallenge=true" | ||
|
||
- it: should have the distributed acme resolver options applied | ||
set: | ||
certificatesResolvers: | ||
my-resolver: | ||
distributedAcme: | ||
email: [email protected] | ||
storage: | ||
kubernetes: true | ||
httpChallenge: | ||
entrypoint: "web" | ||
asserts: | ||
- contains: | ||
path: spec.template.spec.containers[0].args | ||
content: "--certificatesresolvers.my-resolver.distributedAcme.email=email@example.com" | ||
- contains: | ||
path: spec.template.spec.containers[0].args | ||
content: "--certificatesresolvers.my-resolver.distributedAcme.storage.kubernetes=true" | ||
- contains: | ||
path: spec.template.spec.containers[0].args | ||
content: "--certificatesresolvers.my-resolver.distributedAcme.httpChallenge.entrypoint=web" | ||
|
||
- it: should have the tailscale resolver options applied | ||
set: | ||
certificatesResolvers: | ||
my-resolver: | ||
tailscale: true | ||
asserts: | ||
- contains: | ||
path: spec.template.spec.containers[0].args | ||
content: "--certificatesresolvers.my-resolver.tailscale=true" | ||
|
||
- it: should have prometheus annotations with specified values | ||
set: | ||
ports: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,3 +87,18 @@ tests: | |
asserts: | ||
- failedTemplate: | ||
errorMessage: "ERROR: Kubernetes Gateway provider requires ClusterRole. RBAC cannot be namespaced." | ||
- it: should fail when trying to use certResolvers | ||
set: | ||
certResolvers: | ||
myAcmeResolver: | ||
email: [email protected] | ||
dnsChallenge: | ||
provider: myProvider | ||
resolvers: | ||
- 1.1.1.1 | ||
- 8.8.8.8 | ||
tlsChallenge: true | ||
asserts: | ||
- failedTemplate: | ||
errorMessage: "ERROR: certResolvers setting has been removed. See v33.0.0 Changelog." | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should fail with unsupported resolver + (optional) test that we don't configure it by default.