Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct children indentation for logs.access.filters #1225

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

fty4
Copy link
Contributor

@fty4 fty4 commented Oct 15, 2024

What does this PR do?

Move statuscodes, retryattempts, minduration into correct parent (logs.access.filters).
I was a little bit confused when I copied e.g. the statuscodes value from artifacthub which copied logs.access.statuscodes instead of logs.access.filters.statuscodes.

see Traefic docs: Access Logs

Testing

When using following values the correct template is generated:

logs:
  access:
    enabled: true
    filters:
      statuscodes: "404" # correct new indentation
    statuscodes: "404" # wrong old indentation

$ helm template traefik ./traefik/ --values my-val.yaml

>           - "--accesslog.filters.statuscodes=404"

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks for your contribution 👍

@darkweaver87
Copy link
Contributor

darkweaver87 commented Oct 16, 2024

@fty4, just the cherry on the cake, would you mind to add # @schema additionalProperties: false on line 335 of the values.md so the tests will fail if it's wronly indented ?

@fty4
Copy link
Contributor Author

fty4 commented Oct 16, 2024

@darkweaver87 Thank you for that hint - added this to the PR.

Move statuscodes, retryattempts, minduration into correct indentation and adding docs.
@traefiker traefiker merged commit 59073ef into traefik:master Oct 16, 2024
1 check passed
@fty4 fty4 deleted the fix/logs-access-filters branch October 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants