improve updateAttributes

[silenius]

Changes Overview

This is a second attempt (first was in #5154 ) to improve updateAttributes. The first version was broken because it didn't handled range selection properly.

Implementation Approach

The current updateAttributes updates all nodes of the passing typeOrName. It is problematic in some cases, for example imagine a FlexContainer extension which contains 1..n FlexItem (extension) children, and each FlexItem extension can also contain 1..n FlexContainer and so one. If we update, for example, some property (flex align, ...) of a FlexContainer, all FlexContainer parents are updated. This is because ProseMirror node.nodesBetween returns all nodes in the selection range, which includes nodes that cover it (don't know why...).

Checklist

• I have created a changeset for this PR if necessary.
• My changes do not break the library.
• I have added tests where applicable.
• I have followed the project guidelines.
• I have fixed any lint issues.

Related Issues

#3545 #4466 #5154

[changeset-bot]

⚠️ No Changeset found

Latest commit: f2937cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	f2937cc
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/67160aee3cf3cd0008348f8e
😎 Deploy Preview	https://deploy-preview-5738--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[silenius]

there is a single test failing .. but I don't know why

[nperez0111]

Sorry @silenius if you update your branch now it should work. Our branch did not have passing tests

[silenius]

✔️