Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): defineModel type prompt #12170

Closed
wants to merge 0 commits into from
Closed

Conversation

Bayn-Web
Copy link

@Bayn-Web Bayn-Web commented Oct 14, 2024

close #12145

@Bayn-Web Bayn-Web changed the title fix defineModel type prompt (fix #12145) fix(types): defineModel type prompt Oct 14, 2024
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 14, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12170

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12170

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12170

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12170

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12170

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12170

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12170

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12170

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12170

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12170

vue

pnpm add https://pkg.pr.new/vue@12170

commit: 1e97b36

@edison1105
Copy link
Member

Thank you for your PR. I noticed that #12158 made a similar fix and was submitted earlier. If the changes in #12158 are generally correct, I suggest we review it instead of submitting a new PR. This would be more considerate of the existing PR and make maintenance easier.

@Bayn-Web
Copy link
Author

Bayn-Web commented Oct 14, 2024

Thank you for your PR. I noticed that #12158 made a similar fix and was submitted earlier. If the changes in #12158 are generally correct, I suggest we review it instead of submitting a new PR. This would be more considerate of the existing PR and make maintenance easier.

@edison1105
Yes I understand.But I noticed that #12158 will make incorrectly affecting to other code execution.
So should I waiting #12158 closed then pr again or leave some message to #12158?

@edison1105
Copy link
Member

Just leave messages to
#12158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defineModel() wrong 'default' type
2 participants