Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): v-show has a higher priority in SSR #12171

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

linzhe141
Copy link
Contributor

close #12162

@linzhe141 linzhe141 marked this pull request as draft October 14, 2024 04:17
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 14, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12171

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12171

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12171

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12171

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12171

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12171

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12171

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12171

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12171

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12171

vue

pnpm add https://pkg.pr.new/vue@12171

commit: 51be1c5

@linzhe141 linzhe141 closed this Oct 14, 2024
@linzhe141 linzhe141 reopened this Oct 14, 2024
@linzhe141 linzhe141 marked this pull request as ready for review October 14, 2024 06:09
@linzhe141 linzhe141 marked this pull request as draft October 14, 2024 06:52
@linzhe141 linzhe141 marked this pull request as ready for review October 14, 2024 09:14
@edison1105 edison1105 changed the title wip: handle v-show in ssr fix(ssr): v-show has a higher priority in SSR Oct 14, 2024
@edison1105 edison1105 added scope: ssr 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: hydration mismatch when having v-show="false" and style="display: <any>"
2 participants