fix(Transition): fix transition memory leak edge case #12182
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
@vue/compiler-core
@vue/compiler-sfc
@vue/compiler-dom
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
@vue/compiler-dom
@vue/compiler-core
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/shared
@vue/server-renderer
vue
@vue/compat
commit: |
edison1105
added
ready to merge
ferferga
reviewed
Oct 16, 2024
Comment on lines
+261
to
263
| } else if (oldInnerChild) { | ||
| oldInnerChild = undefined | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else if (oldInnerChild) { | |
| oldInnerChild = undefined | |
| } | |
| oldInnerChild = undefined |
Comment on lines
+258
to
+259
| } else { | ||
| oldInnerChild = undefined |
There was a problem hiding this comment.
Suggested change
| } else { | |
| oldInnerChild = undefined |
| enterHooks.delayedLeave = () => { | ||
| delayedLeave() | ||
| delete enterHooks.delayedLeave | ||
| oldInnerChild = undefined |
There was a problem hiding this comment.
Suggested change
| oldInnerChild = undefined |
| // early removal callback | ||
| el[leaveCbKey] = () => { | ||
| earlyRemove() | ||
| el[leaveCbKey] = undefined | ||
| delete enterHooks.delayedLeave | ||
| oldInnerChild = undefined |
There was a problem hiding this comment.
Suggested change
| oldInnerChild = undefined |
| @@ -228,6 +228,7 @@ const BaseTransitionImpl: ComponentOptions = { | |||
| instance.update() | |||
| } | |||
| delete leavingHooks.afterLeave | |||
| oldInnerChild = undefined | |||
There was a problem hiding this comment.
Suggested change
| oldInnerChild = undefined |
core/packages/runtime-core/src/components/BaseTransition.ts Lines 240 to 244 in ec2fcec
|
ferferga
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Good catch
- Regarding Possible memory leak with Transition #12181 (comment), this fixes the problem and tests pass (at least locally).
- Given this is a really tiny change that could pass unnoticed in any refactor, I'd add a reference to the issue as a comment and even a test, I think it could be done with FinalizationRegistry. I could try later if you don't want to do it.
Sorry if my comments sometimes sound dumb or silly, I'm still learning about Vue's codebase.
|
@ferferga
I'm not sure how to do it, maybe you could try it later. |
|
Tests added at #12190 I'm targeting this branch as well, please let me know if I should target main instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12181