Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add typing global custom directives #2951

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hmd-ali
Copy link

@hmd-ali hmd-ali commented Jul 27, 2024

No description provided.

Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit c3a0407
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/66a58774bb310700086ebd10
😎 Deploy Preview https://deploy-preview-2951--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NataliaTepluhina
Copy link
Member

@hmd-ali thank you for the PR! The change looks good but could we please move it to the TypeScript part of the guide? The rest of the directives documentation is plain JS, so adding typing guide looks a bit off. We can add a link at the bottom of directives doc to TS doc too.

@hmd-ali
Copy link
Author

hmd-ali commented Aug 21, 2024

I just noticed your message @NataliaTepluhina. The TS sections are Overview, ts with composition and ts with options api. Where should it go as it's for both apis?

@NataliaTepluhina
Copy link
Member

I just noticed your message @NataliaTepluhina. The TS sections are Overview, ts with composition and ts with options api. Where should it go as it's for both apis?

I would probably split it in two and add to both APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants