Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): bind missing no icon prop in the menu link component #4260

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

dvuckovic
Copy link
Contributor

Building upon #3607 it would be nice to have such control over the dropdown menu links as well.

Use Case

export default {
  themeConfig: {
    nav: [
      {
        text: 'Current release',
        items: [
          text: 'Next release',
          link: 'https://next.example.com',
          target: '_self',
          noIcon: true, // don't want the external link icon here, even though it's on a different domain
        ],
      },
    ],
  },
}

@brc-dd brc-dd merged commit d4712c1 into vuejs:main Oct 12, 2024
4 checks passed
brc-dd added a commit that referenced this pull request Oct 13, 2024
brc-dd added a commit that referenced this pull request Oct 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants