Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MetaMask disconnecting during the connection process. #4347

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

EdouardBougon
Copy link
Collaborator

In certain cases, the MetaMask SDK, when connected via mobile, may emit an accountsChanged event with an empty list, followed shortly by another event containing the correct account list.

In the current implementation of the MetaMask provider, receiving an empty list causes it to disconnect, leading to unintended side effects.

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: ecbd6f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@wagmi/connectors Patch
wagmi Patch
@wagmi/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 4:05pm

@tmm tmm merged commit 5ae49af into wevm:main Oct 17, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants