add my duck #389
Merged
add my duck #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributors.js
Outdated
| @@ -40,4 +40,5 @@ const contributors = [ | |||
| { username: 'Dhruv-Davda', message:'Good Wishes Everyone' }, | |||
| { username: 'Piyush-Goenka', message:'October is hacked' }, | |||
| { username: 'MeuHubPython', message: 'My duck is the best! Happy Hacktoberfest!' }, | |||
| { username: 'xnisha-verma', message: 'Cheers to Hacktoberfest'24 :)' }, | |||
There was a problem hiding this comment.
Hello, thanks for your contribution. be careful, the json file is not correct. Please remove the ` or escape it and remove the comma at the end of the line 🙂
There was a problem hiding this comment.
Thank you for pointing out the issue. I've made necessary changes in json file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here my contribution to "The Duck Gallery".
You must respect the following conditions
your-username.png)contributors.jsfile, the message must be short and respect the code of conductIf the PR doesn't respect those conditions, it will be closed