Add My Duck #390
Merged
Add My Duck #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributors.js
Outdated
| @@ -40,4 +40,5 @@ const contributors = [ | |||
| { username: 'Dhruv-Davda', message:'Good Wishes Everyone' }, | |||
| { username: 'Piyush-Goenka', message:'October is hacked' }, | |||
| { username: 'MeuHubPython', message: 'My duck is the best! Happy Hacktoberfest!' }, | |||
| { username: 'KrishnaShuk', message:''Thanks for this repo, Happy Hacktoberfest 2024!!!' } | |||
There was a problem hiding this comment.
Hello, please fix the json file 🙂
There was a problem hiding this comment.
The json is not valid. Please replace ''Thanks by 'Thanks
There was a problem hiding this comment.
Thanks @jeanphi-baconnais ,I have resolved the conflict.
|
pls merge my code with the hacktober tag. |
Hello @KrishnaShuk , I will look this PR. FYI, Hacktoberfest isn't needed because the project get it. |
jeanphi-baconnais
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here my contribution to "The Duck Gallery".