Skip to content

Commit

Permalink
homescreen_icon: Swap icon 'globe' with 'list' for web UI parity.
Browse files Browse the repository at this point in the history
Web Zulip's all-messages icon is an inverted list icon, so we're
swapping mobile's all-messages icon to match.

Fixes: #5303
  • Loading branch information
Leslie Ngo authored and Leslie Ngo committed Nov 8, 2022
1 parent 2130e34 commit 441b6d9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/common/Icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,4 @@ export const IconGroup: SpecificIconType = makeIcon(FontAwesome, 'group');
export const IconPlus: SpecificIconType = makeIcon(Feather, 'plus');
// eslint-disable-next-line react/function-component-definition
export const IconWebPublic: SpecificIconType = props => <ZulipIcon name="globe" {...props} />;
export const IconAllMessages: SpecificIconType = makeIcon(Feather, 'align-left');
9 changes: 6 additions & 3 deletions src/main/HomeScreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import LoadingBanner from '../common/LoadingBanner';
import ServerCompatBanner from '../common/ServerCompatBanner';
import ServerPushSetupBanner from '../common/ServerPushSetupBanner';
import { OfflineNoticePlaceholder } from '../boot/OfflineNoticeProvider';
import { Icon } from '../common/Icons';
import { IconAllMessages } from '../common/Icons';

const styles = createStyleSheet({
wrapper: {
Expand All @@ -45,12 +45,15 @@ export default function HomeScreen(props: Props): Node {
<OfflineNoticePlaceholder />
<View style={styles.iconList}>
<TopTabButtonGeneral
name="globe"
onPress={() => {
dispatch(doNarrow(HOME_NARROW));
}}
>
<Icon size={24} style={{ textAlign: 'center ' }} color={BRAND_COLOR} name="globe" />
<IconAllMessages
size={24}
style={{ textAlign: 'center', transform: [{ scaleY: -1 }] }}
color={BRAND_COLOR}
/>
</TopTabButtonGeneral>
<TopTabButton
name="star"
Expand Down

0 comments on commit 441b6d9

Please sign in to comment.