Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:announcements by the screen reader interrupt any existing speech #5644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix:announcements by the screen reader interrupt any existing speech #5644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/boot/OfflineNoticeProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,10 @@ export function OfflineNoticeProvider(props: ProviderProps): Node {
// another app.)

if (shouldShowUncertaintyNotice && !haveAnnouncedUncertain.current) {
// TODO(react-native-68): Use announceForAccessibilityWithOptions to
// queue this behind any in-progress announcements
AccessibilityInfo.announceForAccessibility(_('Zulip’s Internet connection is uncertain.'));
AccessibilityInfo.announceForAccessibilityWithOptions(
_('Zulip’s Internet connection is uncertain.'),
{ queue: true },
);
haveAnnouncedUncertain.current = true;
}

Expand All @@ -226,9 +227,7 @@ export function OfflineNoticeProvider(props: ProviderProps): Node {
isOnline === true
&& (haveAnnouncedOffline.current || haveAnnouncedUncertain.current)
) {
// TODO(react-native-68): Use announceForAccessibilityWithOptions to
// queue this behind any in-progress announcements
AccessibilityInfo.announceForAccessibility(_('Zulip is online.'));
AccessibilityInfo.announceForAccessibilityWithOptions(_('Zulip is online.'), { queue: true });
haveAnnouncedOffline.current = false;
haveAnnouncedUncertain.current = false;
}
Expand Down