Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drees 110 lpp extractor #262

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Drees 110 lpp extractor #262

wants to merge 3 commits into from

Conversation

strayMat
Copy link
Contributor

Adding logics for a new extractor / new event :

  • productOrService : the original data is taken from the ER_TIP_F table, a secondary (affinée) table from the DCIR. It concerns the LPP events which address all sort of products and services reimbursed.
    Some examples are , medical devices, prostheses, bandages, ...

- needed to add ER_TIP_F table to the test data (changed DCIR_bio to DCIR_all, a broader version of the original DCIR test table where biology and LPP (ER_TIP_F) were added.
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #262 into develop will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #262      +/-   ##
===========================================
+ Coverage    93.50%   93.56%   +0.06%     
===========================================
  Files          218      220       +2     
  Lines         2586     2596      +10     
  Branches        72       70       -2     
===========================================
+ Hits          2418     2429      +11     
+ Misses         168      167       -1     
Impacted Files Coverage Δ
...tractors/events/acts/DcirMedicalActExtractor.scala 96.00% <ø> (ø)
...hnique/cmap/cnam/etl/events/ProductOrService.scala 100.00% <100.00%> (ø)
...uctsorservices/DcirProductOrServiceExtractor.scala 100.00% <100.00%> (ø)
.../cnam/etl/extractors/sources/dcir/DcirSource.scala 100.00% <100.00%> (ø)
...dy/fall/extractors/FallHospitalStayExtractor.scala 80.00% <100.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714aa3e...9b62dea. Read the comment docs.

@strayMat strayMat requested a review from dsun0720 August 4, 2020 09:34
- Changed DcirRowActExtractor to accept other event types than MedicalAct
- Make DcirProductOrServiceExtractor extends DcirRowActExtractor
@strayMat
Copy link
Contributor Author

strayMat commented Sep 9, 2020

Hello @dsun0720 ! We needed to take into account these events for a study and thus implemented this new extractor. What do you think of this addition ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant