Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMwareGuestInfoService is not implementing static network configuration #78

Open
janitha opened this issue Aug 20, 2021 · 5 comments · May be fixed by #83
Open

VMwareGuestInfoService is not implementing static network configuration #78

janitha opened this issue Aug 20, 2021 · 5 comments · May be fixed by #83

Comments

@janitha
Copy link

janitha commented Aug 20, 2021 •
edited
Loading

VMwareGuestInfoService is not implementing the static network configuration at the moment (I haven't tried this to verify it, but looking at the source, VMwareGuestInfoService is not implementing get_network_details nor get_network_details_v2)

Before I started working on a PR, I wanted to know if there was a specific reason this wasn't included? cc @rgl Thanks!
@akutz
Copy link

akutz commented Aug 23, 2021

cc @akutz

@rgl
Copy link
Contributor

rgl commented Sep 9, 2021 •
edited
Loading

At the time I didn't known about it. Funnily enough, today I was looking for it! :-)

@janitha, do you want to work on it? I can do it otherwise.

I think its a matter of returning the metadata network key value. Which is aligned with https://github.com/canonical/cloud-init/blame/8b4a9bc7b81e61943af873bad92e2133f8275b0b/doc/rtd/topics/datasources/vmware.rst#L219-L225.

@janitha
Copy link
Author

janitha commented Sep 9, 2021

@rgl I haven't started on this yet and a bit tied up with other work, you can take this on, much appreciated!

@kimbernator kimbernator linked a pull request Nov 22, 2021 that will close this issue
Open
@twalcari
Copy link

@ader1990 Can this PR be merged please?

@hideakihal hideakihal mentioned this issue Sep 26, 2022
Open
@FlorianLaunay
Copy link
Contributor

Feature will now be provided by #107

@FlorianLaunay FlorianLaunay mentioned this issue Dec 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable static network configuration via vmware guestinfo kimbernator/cloudbase-init
5 participants
@rgl @akutz @janitha @twalcari @FlorianLaunay